main: hint at device state when a hardware wallet fails to open - #4668
Open
reservedbytes wants to merge 1 commit into
Open
main: hint at device state when a hardware wallet fails to open#4668reservedbytes wants to merge 1 commit into
reservedbytes wants to merge 1 commit into
Conversation
jpk68
approved these changes
Jul 30, 2026
selsta
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a hardware wallet fails to open — locked, disconnected, or with the Monero app
closed — the password dialog shows the raw error from the device layer and nothing
else. For a locked Ledger that is:
Nothing there tells the user to unlock the device, so it reads like a failure of the
wallet rather than a device that needs attention.
Change
When a wallet fails to open and the wallet is hardware-backed, append a line saying
what to check. The device type comes from
wallet.isLedger()/wallet.isTrezor(),matching how
TxConfirmationDialog.qmlalready distinguishes them, so Trezor usersare not told to open a Monero app that does not exist on their device.
Why detect the device instead of matching the error text
Device-layer error strings change over time: the status word name in this error was
renamed, and monero-project/monero#10997 replaces the hex dump altogether. Matching on
isHwBacked()is unaffected by wording changes, and covers device failures that havenot been catalogued yet.
Related prior work: #3508.
Closes #3507